centering changes #239
Merged
centering changes #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`c` now centers on the bounding sphere of current frame if no atoms selected initiallly center the camera on the bounding sphere on start up added event.js file to improve code organisation
for more information, see https://pre-commit.ci
PythonFZ
requested changes
Oct 13, 2023
Now center corresponds to overall center if no atoms are selected and to the center of selected atoms otherwise Also inverted the if loop in World since the if part was empty
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 48.75% 48.75%
=======================================
Files 7 7
Lines 281 281
=======================================
Hits 137 137
Misses 144 144 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@PythonFZ check the newest version. This changes the Atoms object, make sure you're happy with that. Should not affect overall performance but adds a nice indexing functionality. Might be useful elsewhere? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cnow centers on the bounding sphere of current frame if no atoms selectedinitiallly center the camera on the bounding sphere on start up
added event.js file to improve code organisation
@PythonFZ, I didn't move the other events to the
event.jsbut should be easy to do, and would make the code a bit cleaner.