Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Plotting #614

Merged
merged 53 commits into from
Aug 26, 2024
Merged

Improved Plotting #614

merged 53 commits into from
Aug 26, 2024

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Aug 14, 2024

## DO NOT MERGE UNTIL PERFORMANCE ISSUE IS RESOLVED!

  • zntrack support
  • metadata selection does not work, e.g. with colormap - need a better method.
  • when to show the plotting window (plots refresh)
  • fullscreen plots
  • share selected frames across webclients
  • check what goes wrong in edge
  • new window plots
  • ticks are invisible in dark mode
  • to gradient or not to use gradient
  • upload
  • selection does not work if there is only a single plot
  • initial view too small / no plots shown (default empty plot?)
  • 2D plot does not work, if the value was not initially changed?
  • large plots issue
  • tooltips
  • reduce ticks when there are too many, maybe use resolution as a reference
  • every step triggers a full react re-rendering of the entire progress bar - that is painfully slow. Maybe only show every second / third .. tile once they get very small?

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 26.38889% with 53 lines in your changes missing coverage. Please review.

Project coverage is 55.88%. Comparing base (d8b5353) to head (5113862).

Files Patch % Lines
zndraw/server/events.py 19.23% 21 Missing ⚠️
zndraw/utils.py 16.66% 15 Missing ⚠️
tests/test_analysis.py 0.00% 8 Missing ⚠️
zndraw/tasks/__init__.py 37.50% 5 Missing ⚠️
zndraw/analyse/__init__.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   56.90%   55.88%   -1.02%     
==========================================
  Files          35       35              
  Lines        2775     2822      +47     
==========================================
- Hits         1579     1577       -2     
- Misses       1196     1245      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PythonFZ PythonFZ linked an issue Aug 20, 2024 that may be closed by this pull request
Comment on lines +41 to +47
const MoveCameraTarget = ({
controlsRef,
colorMode,
}: {
controlsRef: any;
colorMode: string;
}) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to a module

zndraw/analyse/__init__.py Outdated Show resolved Hide resolved
zndraw/tasks/__init__.py Outdated Show resolved Hide resolved
@PythonFZ PythonFZ marked this pull request as ready for review August 26, 2024 10:32
@PythonFZ PythonFZ merged commit 418078b into main Aug 26, 2024
4 checks passed
@PythonFZ PythonFZ deleted the plotting-updates branch August 26, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

block frames add -p/--plots option
2 participants