-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Plotting #614
Merged
Merged
Improved Plotting #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
- Coverage 56.90% 55.88% -1.02%
==========================================
Files 35 35
Lines 2775 2822 +47
==========================================
- Hits 1579 1577 -2
- Misses 1196 1245 +49 ☔ View full report in Codecov by Sentry. |
PythonFZ
force-pushed
the
plotting-updates
branch
from
August 15, 2024 08:39
6ac9664
to
3dca9b8
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Closed
PythonFZ
commented
Aug 20, 2024
Comment on lines
+41
to
+47
const MoveCameraTarget = ({ | ||
controlsRef, | ||
colorMode, | ||
}: { | ||
controlsRef: any; | ||
colorMode: string; | ||
}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to a module
PythonFZ
commented
Aug 20, 2024
PythonFZ
commented
Aug 20, 2024
PythonFZ
commented
Aug 20, 2024
PythonFZ
commented
Aug 20, 2024
PythonFZ
commented
Aug 20, 2024
PythonFZ
commented
Aug 20, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into plotting-updates
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## DO NOT MERGE UNTIL PERFORMANCE ISSUE IS RESOLVED!