Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight current step in plotly plots #651

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Sep 20, 2024

  • fail fast if the x/y data is not set
  • option to activate line / marker
  • fix Properties2D / Properties1D? fix aspect ratio?
  • fix layout reset when step changes (how would this work with the line, just update this one part and not set the entire layout)
  • marker style
  • use the color of the data line
  • use znsocket npm to fix bookmarks

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.37%. Comparing base (7dd970d) to head (d098790).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   54.43%   54.37%   -0.07%     
==========================================
  Files          35       35              
  Lines        2917     2917              
==========================================
- Hits         1588     1586       -2     
- Misses       1329     1331       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants