Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Konsti fix main #113

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Konsti fix main #113

merged 5 commits into from
Apr 8, 2024

Conversation

KonstiNik
Copy link
Member

Fixing two issues on main

  • black style
  • removing the fixed nt-version in requirements

@KonstiNik KonstiNik requested a review from SamTov April 5, 2024 08:44
@KonstiNik
Copy link
Member Author

KonstiNik commented Apr 5, 2024

We get a pmapping error in our huggingface flax test when using the latest version of jax - 0.4.26
But only with this version.

I would suggest to first wait for other updates. What do you say @SamTov ?

Copy link
Member

@SamTov SamTov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, by looking only at the CI I can't see the exact HF error as it isn't recorded well in the tests. What excatly is the problem?

requirements.txt Outdated Show resolved Hide resolved
@KonstiNik
Copy link
Member Author

Looks good, by looking only at the CI I can't see the exact HF error as it isn't recorded well in the tests. What excatly is the problem?

It looks like a compilation error when mapping the hf model with neural tangents.
But what actually happens I don't know. I was able to reproduce it, but only with the latest version of jax (released 2 days ago).

@KonstiNik
Copy link
Member Author

KonstiNik commented Apr 8, 2024

Created an issue for the version constraint: #115 (comment)

@KonstiNik KonstiNik merged commit cc82976 into main Apr 8, 2024
6 checks passed
@KonstiNik KonstiNik deleted the Konsti_fix_main branch April 8, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants