Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requirements, clean up small test issues #117

Merged
merged 8 commits into from
May 7, 2024
Merged

Fix requirements, clean up small test issues #117

merged 8 commits into from
May 7, 2024

Conversation

SamTov
Copy link
Member

@SamTov SamTov commented Apr 24, 2024

No description provided.

KonstiNik
KonstiNik requested changes May 7, 2024
View reviewed changes
Copy link
Member

@KonstiNik KonstiNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!
Very nice to the requirements correct.

I think there are two unwanted changes, you could take a look at.

znnl/models/jax_model.py Outdated Show resolved Hide resolved
znnl/training_strategies/simple_training.py Show resolved Hide resolved
@SamTov SamTov merged commit ac59d15 into main May 7, 2024
6 checks passed
@SamTov SamTov deleted the requirements branch May 7, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonstiNik KonstiNik KonstiNik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamTov @KonstiNik