[WIP] Static mesh support #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would address #3 |
Fixes a bug where if you initialize the static mesh first, the number of frames get set to 1
|
Moved to new PR |
SamTov
reviewed
Jun 13, 2024
There was a problem hiding this comment.
I like the PR! I think there is a cleaner way of dealing with the meshes, namely having lists at the start of state and dynamic meshes, thereby removing any need to perform the logic check. However, this is a large restructure of the code that I would leave for a general cleanup PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option for meshes to be static, meaning they will only be loaded in once and not changed during the following frames. This significantly improves rendering time for a larger non-moving mesh.
Can be added to
vis.Particleandvis.VectorFieldby simply giving them thestatic = Trueparameter.Note that static objects only take in
positionin the shape of (n_part, n_dim)