remove unneeded Scope requirement in FtpAccessors #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks again for your MR ! and catching to close the inputstream :) |
regis-leray
reviewed
Aug 2, 2023
regis-leray
approved these changes
Aug 2, 2023
|
Thanks for the review, @regis-leray. That file you asked about is auto-generated by |
|
@mberndt123 you can merge |
|
I can't merge that, I don't have the required permissions. Can you do that for me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zio-ftp opens some streams to upload files, but it doesn't close them and thus leaks the
Scoperequirement. There's no reason to keep these streams open after uploading has completed, so let's just close them and remove theScoperequirement.