420 - improve readFile Stream finalization #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regis-leray
force-pushed
the
420
branch
6 times, most recently
from
f3fd1db
to
b5ff912
Compare
|
@mberndt123 sorry for the delay Thank again for your great input, and the investigation. Here an implementation, which propagate the error if the pending command operation fail :) I have updated the test to make sure if there is a failure during the finaliser it gets propagated to the error channel |
This was referenced Oct 10, 2024
regis-leray
force-pushed
the
420
branch
11 times, most recently
from
6d350f4
to
5400028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #420
closes #227