Merge pull request #11 from caos/feat/customEndpoints

feat: custom absolute endpoints
zitadel · Feb 27, 2020 · 7f486a5 · 7f486a5
2 parents c3e583b + 660519a
commit 7f486a5
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 16 deletions.
diff --git a/example/server/default/default.go b/example/server/default/default.go
@@ -21,7 +21,7 @@ func main() {
 		Port:      "9998",
 	}
 	storage := mock.NewAuthStorage()
-	handler, err := op.NewDefaultOP(ctx, config, storage, op.WithCustomTokenEndpoint("test"))
+	handler, err := op.NewDefaultOP(ctx, config, storage, op.WithCustomTokenEndpoint(op.NewEndpoint("test")))
 	if err != nil {
 		log.Fatal(err)
 	}

diff --git a/pkg/op/default_op.go b/pkg/op/default_op.go
@@ -26,11 +26,11 @@ const (
 
 var (
 	DefaultEndpoints = &endpoints{
-		Authorization:         defaultAuthorizationEndpoint,
-		Token:                 defaulTokenEndpoint,
-		IntrospectionEndpoint: defaultIntrospectEndpoint,
-		Userinfo:              defaultUserinfoEndpoint,
-		JwksURI:               defaultKeysEndpoint,
+		Authorization:         NewEndpoint(defaultAuthorizationEndpoint),
+		Token:                 NewEndpoint(defaulTokenEndpoint),
+		IntrospectionEndpoint: NewEndpoint(defaultIntrospectEndpoint),
+		Userinfo:              NewEndpoint(defaultUserinfoEndpoint),
+		JwksURI:               NewEndpoint(defaultKeysEndpoint),
 	}
 )
 

diff --git a/pkg/op/endpoint.go b/pkg/op/endpoint.go
@@ -2,14 +2,28 @@ package op
 
 import "strings"
 
-type Endpoint string
+type Endpoint struct {
+	path string
+	url  string
+}
+
+func NewEndpoint(path string) Endpoint {
+	return Endpoint{path: path}
+}
+
+func NewEndpointWithURL(path, url string) Endpoint {
+	return Endpoint{path: path, url: url}
+}
 
 func (e Endpoint) Relative() string {
-	return relativeEndpoint(string(e))
+	return relativeEndpoint(e.path)
 }
 
 func (e Endpoint) Absolute(host string) string {
-	return absoluteEndpoint(host, string(e))
+	if e.url != "" {
+		return e.url
+	}
+	return absoluteEndpoint(host, e.path)
 }
 
 func (e Endpoint) Validate() error {

diff --git a/pkg/op/endpoint_test.go b/pkg/op/endpoint_test.go
@@ -6,20 +6,25 @@ import (
 	"github.com/caos/oidc/pkg/op"
 )
 
-func TestEndpoint_Relative(t *testing.T) {
+func TestEndpoint_Path(t *testing.T) {
 	tests := []struct {
 		name string
 		e    op.Endpoint
 		want string
 	}{
 		{
 			"without starting /",
-			op.Endpoint("test"),
+			op.NewEndpoint("test"),
 			"/test",
 		},
 		{
 			"with starting /",
-			op.Endpoint("/test"),
+			op.NewEndpoint("/test"),
+			"/test",
+		},
+		{
+			"with url",
+			op.NewEndpointWithURL("/test", "http://test.com/test"),
 			"/test",
 		},
 	}
@@ -44,28 +49,34 @@ func TestEndpoint_Absolute(t *testing.T) {
 	}{
 		{
 			"no /",
-			op.Endpoint("test"),
+			op.NewEndpoint("test"),
 			args{"https://host"},
 			"https://host/test",
 		},
 		{
 			"endpoint without /",
-			op.Endpoint("test"),
+			op.NewEndpoint("test"),
 			args{"https://host/"},
 			"https://host/test",
 		},
 		{
 			"host without /",
-			op.Endpoint("/test"),
+			op.NewEndpoint("/test"),
 			args{"https://host"},
 			"https://host/test",
 		},
 		{
 			"both /",
-			op.Endpoint("/test"),
+			op.NewEndpoint("/test"),
 			args{"https://host/"},
 			"https://host/test",
 		},
+		{
+			"with url",
+			op.NewEndpointWithURL("test", "https://test.com/test"),
+			args{"https://host"},
+			"https://test.com/test",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {