feat: issuer from Forwarded header #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #443 +/- ##
==========================================
+ Coverage 53.84% 53.96% +0.11%
==========================================
Files 74 74
Lines 5811 5830 +19
==========================================
+ Hits 3129 3146 +17
- Misses 2422 2424 +2
Partials 260 260
|
livio-a
approved these changes
Sep 7, 2023
|
🎉 This PR is included in version 2.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the need in zitadel to run OIDC behind a proxy,
we need to be able to overwrite the Host from the request.
To provide that, it is now possible to start a provider that parses the standarized
Forwardedheader with a fallback to the Request Host field.In order not to break installations that might be already running behind a proxy with the header set, a seperate constructor for the provider is added for the new usecase.
Definition of Ready