fix(op): do not redirect to unverified uri on error #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-arrange Auth request validation.
Any error from step 1 up till and including 4 will not result in a redirect. The error is returned to the user-agent.
Errors from 5 and beyond will result in a redirect.
This fixes behavior to be compliant with Oauth2 RFC 6749, section 4.1.2.1:
Closes #627
Note: This PR does address the
op.Server
interface for 2 reasons:Definition of Ready