chore(collector): Make CollectorFactory methods final using annotation

zlodes · Jul 26, 2023 · a273452 · a273452
1 parent 9f9ad1c
commit a273452
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/phpcs.xml b/phpcs.xml
@@ -254,7 +254,7 @@
                 <element value="@mixin"/>
                 <element value="@codeCoverageIgnore,@deprecated"/>
                 <element value="@template,@psalm-template,@psalm-type,@psalm-import-type" />
-                <element value="@internal,@psalm-internal,@psalm-immutable" />
+                <element value="@internal,@final,@psalm-internal,@psalm-immutable" />
                 <element value="@no-named-arguments" />
                 <element value="@inheritDoc"/>
                 <element value="@property\"/>

diff --git a/src/Collector/ByType/CounterCollector.php b/src/Collector/ByType/CounterCollector.php
@@ -15,7 +15,6 @@
 
 /**
  * @internal Zlodes\PrometheusClient\Collector
- *
  * @final
  */
 class CounterCollector

diff --git a/src/Collector/ByType/GaugeCollector.php b/src/Collector/ByType/GaugeCollector.php
@@ -14,7 +14,6 @@
 
 /**
  * @internal Zlodes\PrometheusClient\Collector
- *
  * @final
  */
 class GaugeCollector

diff --git a/src/Collector/ByType/HistogramCollector.php b/src/Collector/ByType/HistogramCollector.php
@@ -14,7 +14,6 @@
 
 /**
  * @internal Zlodes\PrometheusClient\Collector
- *
  * @final
  */
 class HistogramCollector

diff --git a/src/Collector/CollectorFactory.php b/src/Collector/CollectorFactory.php
@@ -18,22 +18,24 @@
  */
 class CollectorFactory
 {
-    final public function __construct(
+    public function __construct(
         private readonly Registry $registry,
         private readonly Storage $storage,
         private readonly LoggerInterface $logger,
     ) {
     }
 
     /**
+     * @final
+     *
      * @param non-empty-string $counterName
      *
      * @return CounterCollector
      *
      * @throws MetricNotFoundException
      * @throws MetricHasWrongTypeException
      */
-    final public function counter(string $counterName): CounterCollector
+    public function counter(string $counterName): CounterCollector
     {
         $counter = $this->registry->getCounter($counterName);
 
@@ -45,14 +47,16 @@ final public function counter(string $counterName): CounterCollector
     }
 
     /**
+     * @final
+     *
      * @param non-empty-string $gaugeName
      *
      * @return GaugeCollector
      *
      * @throws MetricNotFoundException
      * @throws MetricHasWrongTypeException
      */
-    final public function gauge(string $gaugeName): GaugeCollector
+    public function gauge(string $gaugeName): GaugeCollector
     {
         $gauge = $this->registry->getGauge($gaugeName);
 
@@ -63,7 +67,10 @@ final public function gauge(string $gaugeName): GaugeCollector
         );
     }
 
-    final public function histogram(string $histogramName): HistogramCollector
+    /**
+     * @final
+     */
+    public function histogram(string $histogramName): HistogramCollector
     {
         $histogram = $this->registry->getHistogram($histogramName);