Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSearch: Unindex/Reindex depending on node visibility #776 #331

Merged
merged 4 commits into from
Nov 6, 2024
Merged

OpenSearch: Unindex/Reindex depending on node visibility #776 #331

merged 4 commits into from
Nov 6, 2024

Conversation

zmsdev
Copy link
Contributor

@zmsdev zmsdev commented Nov 5, 2024 •
edited by drfho
Loading

@zmsdev zmsdev requested a review from drfho November 5, 2024 17:54
drfho
drfho requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@drfho drfho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: code change does not execute unindexing

[0] Example node that is indexed
image

[2] After inactivating the node, search index item persists
image

@drfho
Copy link
Contributor

drfho commented Nov 6, 2024

@zmsdev
The currect refact 757cb46 removes in case of missing filter.match the page-container from index.
A problem here might be overhead of unnecessary removal-tries. But as far I see the function reindex_node() is not used by full-indexing/reindex (manage_objects_add()). so this might be specific enough. Your opinion?

@drfho drfho merged commit 324641c into main Nov 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drfho drfho drfho requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmsdev @drfho