Bug fix: adding fallback for nameless customers #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is cleared and needs to be refilled before saving. Adding the pre 6.5.3 strategy as fallback method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the duplicate, had to reorder my branches...
We have a few technical accounts (from LDAP) used for stock keeping who don't have a name. before 6.5.3 these were displayed by their email address.
6.5.3 tries to show customer users by their Title, First name and Last name which is fine, however when editing a CI which has a nameless user set in a Customer field, the field is cleared and manually needs to be re-filled before saving to not lose that information.
This commit adds the old way of "resolving" the display information for these users as a fallback in case no name can be determined.