MAJOR BUG! keep moves reference

We reassign Moves to a new Empty List every time we make a move. Since we AREN'T referencing it in a for-each loop, it would get (supposedly) picked up by the GC. Meaning boardState.Moves[i] was referring to WRONG moves
znxftw · Dec 18, 2024 · 39ba93d · 39ba93d
1 parent 41fa4e5
commit 39ba93d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Rudim/Search/Quiescence.cs b/Rudim/Search/Quiescence.cs
@@ -29,11 +29,11 @@ public static int Search(BoardState boardState, int alpha, int beta, Cancellatio
             MoveOrdering.SortMoves(boardState);
 
 
-            for (int i = 0; i < boardState.Moves.Count; ++i)
+            foreach (var t in boardState.Moves)
             {
                 if (cancellationToken.IsCancellationRequested)
                     break;
-                Move move = boardState.Moves[i];
+                Move move = t;
                 if (!move.IsCapture())
                     break; // If sorted, once a quiet move is reached we won't need to visit the remaining nodes