refactor(subject previews): allow for single series JSON data subjects #7123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatyourgreens
commented
Jun 6, 2024
Comment on lines
+3
to
+10
| function getXYData(data) { | ||
| return { | ||
| data: data.x.map((x, index) => ({ x, y: data.y[index] })), | ||
| pointStyle: 'circle', | ||
| backgroundColor: '#ffffff', | ||
| borderColor: '#000000' | ||
| } | ||
| } |
There was a problem hiding this comment.
This is new, to handle subjects with { data: { x: number[], y: number[] }}. Otherwise, the rest of the code in this PR should be unchanged from the original, just refactored into smaller functions.
eatyourgreens
commented
Jun 6, 2024
Comment on lines
44
to
55
| if(data.x && data.y) { | ||
| return { | ||
| data: { | ||
| x: data.x, | ||
| y: data.y | ||
| } | ||
| }); | ||
| } | ||
| if (data.datasets) { | ||
| datasets = data.datasets | ||
| }, | ||
| { | ||
| chartOptions: { | ||
| xAxisLabel: 'Days', | ||
| yAxisLabel: 'Brightness' | ||
| } | ||
| }; |
There was a problem hiding this comment.
This converts PH-TESS subjects from { x, y } to { data: { x, y }, chartOptions } (when the location MIME type is application/json.)
eatyourgreens
force-pushed
the
data-subject-preview
branch
from
9b1096c
to
c901cfe
Compare
eatyourgreens
force-pushed
the
data-subject-preview
branch
from
09fb922
to
b863e9b
Compare
eatyourgreens
force-pushed
the
data-subject-preview
branch
from
b863e9b
to
e11b0e8
Compare
Refactor previews for JSON data subjects to include subjects with a single `x,y` data series. `getDatasets(data)` reflects on the type of data, then calls an appropriate helper function to convert `data` into an array of `chart.js` datasets.
eatyourgreens
force-pushed
the
data-subject-preview
branch
from
e11b0e8
to
939d235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor previews for JSON data subjects to include subjects with a single
x,ydata series eg. PH-TESS subjects.getDatasets(data)reflects on the type of data, then calls an appropriate helper function to convertdatainto an array ofchart.jsdatasets.You can check the subject viewer for a JSON data subject on Black Hole Hunters Talk
eg. https://local.zooniverse.org:3735/projects/cobalt-lensing/black-hole-hunters/talk/subjects/96013284?env=production
d.map is not a functionfor subject previews, when you pass an{ x, y }subject to the chart plotter. See Issue with Json data charts Preview front-end-monorepo#6118.Required Manual Testing
Review Checklist
npm ciand app works as expected?Optional
ChangeListenerorPromiseRenderercomponents with code that updates component state?