Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(classifier): automatically sync drawing annotations #5923

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(classifier): automatically sync drawing annotations #5923

wants to merge 4 commits into from
+85 −41

Commits on Jun 17, 2024

  1. refactor: automatically sync drawing annotations 

    - Add an `annotation.actualTask` view to drawing tasks and transcription tasks.
- Add an `autorun` listener which observes `self.actualTask.marks`  for changes, and updates the annotation value.
- Remove the manual `annotation.update(newValue)` when a new mark is drawn.

This might be a more robust fix for problems where the classification is not updated properly after a change to a drawing tool. It should keep drawing annotations in sync with their corresponding drawing tools.
    @eatyourgreens
    eatyourgreens committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0fb0fda View commit details
    Browse the repository at this point in the history

  2. Test drawings with multiple frames

    @eatyourgreens
    eatyourgreens committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2f02675 View commit details
    Browse the repository at this point in the history

  3. Use annotation.value in classification snapshots 

    Use `annotation.value` to generate mark snapshots for `annotation.toSnapshot()`.
    @eatyourgreens
    eatyourgreens committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    71d5d65 View commit details
    Browse the repository at this point in the history

  4. Clarify the annotation value

    @eatyourgreens
    eatyourgreens committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    028c50e View commit details
    Browse the repository at this point in the history