Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classifier README updates #6159

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Classifier README updates #6159

merged 2 commits into from
Oct 1, 2024

Conversation

kieftrav
Copy link
Contributor

@kieftrav kieftrav commented Jul 7, 2024

Packages

lib-classifier

Describe your changes

The purpose of this Classifier Documentation PR is to link together all of the existing README’s in the Classifier and to provide some visual/overarching sense of the code architecture and underlying data models that tie together the Classifier. Because this has no effect on the underlying code, this can be merged in without testing / other deployment-oriented concerns.

Main README

  • Updated to give more of an overview of what the Classifier is and the underlying concepts that create the classifier
  • Add some Mermaid diagrams to visualize the relationship between the SubjectViewer, TaskArea, and RootStore
  • Describe the Render process with links to other Classifier documentation
  • Add link to the Hooks Readme so they are not orphaned

SubjectViewer README

  • Add links to the FlipbookViewer and SeparateFramesViewer

Tasks README

  • Created a more robust explanation of Tasks with links to those Tasks that have documentation
  • Added Mermaid diagram to explain the conceptual structure of a Task

Store README

  • Updated main README with a stronger conceptual explanation of the data models used
  • Added dependency graph on the Models to explain how we translate the underlying Panoptes data structure into what’s usable by the Classifier
  • Add links to other Stores and Utilities

Store Feedback README

  • Added link to the Strategies README and the Column Drawing Task README

@kieftrav kieftrav marked this pull request as draft July 7, 2024 22:13
@coveralls
Copy link

coveralls commented Jul 7, 2024

Coverage Status

coverage: 78.507% (-0.008%) from 78.515%
when pulling 88dceb8 on classifier-documentation
into 5267028 on master.

@kieftrav kieftrav requested a review from a team August 6, 2024 14:14
@kieftrav kieftrav added the documentation Add the documentation for something label Aug 6, 2024
@kieftrav kieftrav marked this pull request as ready for review August 6, 2024 14:14
@goplayoutside3
Copy link
Contributor

@kieftrav just a small request, but if this PR is ready for full review I think the WIP needs to be removed from the name in order for the CI checks to pass.

@kieftrav kieftrav changed the title WIP: README updates Classifier README updates Aug 8, 2024
@shaunanoordin shaunanoordin self-assigned this Aug 29, 2024
@shaunanoordin shaunanoordin self-requested a review August 29, 2024 13:42
Copy link
Member

@shaunanoordin shaunanoordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

This PR is a significant documentation update for FEM.

  • Additional context has been added on multiple documents.
  • More importantly, a lot of stray READMEs have been linked together, providing a much better overall picture to the repo.
  • Mermaid charts have been added to provide a (much welcome) visual aid for a more holistic view of the codebase.

Status

The documentation makes sense to me (a dev with a lot of experience on FEM) and - to my best judgement - would also mostly make sense to a new dev trying to understand FEM.

I've added some notes - the only major suggestion being that the lib-classifier README should mention the Question/DataViz/Survey tasks, even if they aren't individually documented - but otherwise this PR is good to go. 👍

packages/lib-classifier/src/plugins/tasks/readme.md Outdated Show resolved Hide resolved
packages/lib-classifier/README.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the approved This PR is approved for merging label Aug 29, 2024
@goplayoutside3
Copy link
Contributor

@kieftrav are you planning to update / merge this PR?

@kieftrav
Copy link
Contributor Author

@goplayoutside3 - yes, planning to make the suggested changes. It's been on the backburner due to other priorities but hopefully end of this week.

…s and provide some additional context on the overarching code architecture and underlying data models.
@kieftrav kieftrav merged commit e2cb756 into master Oct 1, 2024
7 checks passed
@kieftrav kieftrav deleted the classifier-documentation branch October 1, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging documentation Add the documentation for something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants