-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classifier README updates #6159
Conversation
4b72393
to
e6b2728
Compare
@kieftrav just a small request, but if this PR is ready for full review I think the WIP needs to be removed from the name in order for the CI checks to pass. |
e6b2728
to
8b44baf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Review
This PR is a significant documentation update for FEM.
- Additional context has been added on multiple documents.
- More importantly, a lot of stray READMEs have been linked together, providing a much better overall picture to the repo.
- Mermaid charts have been added to provide a (much welcome) visual aid for a more holistic view of the codebase.
Status
The documentation makes sense to me (a dev with a lot of experience on FEM) and - to my best judgement - would also mostly make sense to a new dev trying to understand FEM.
I've added some notes - the only major suggestion being that the lib-classifier README should mention the Question/DataViz/Survey tasks, even if they aren't individually documented - but otherwise this PR is good to go. 👍
@kieftrav are you planning to update / merge this PR? |
@goplayoutside3 - yes, planning to make the suggested changes. It's been on the backburner due to other priorities but hopefully end of this week. |
…s and provide some additional context on the overarching code architecture and underlying data models.
8b44baf
to
88dceb8
Compare
Packages
lib-classifier
Describe your changes
The purpose of this Classifier Documentation PR is to link together all of the existing README’s in the Classifier and to provide some visual/overarching sense of the code architecture and underlying data models that tie together the Classifier. Because this has no effect on the underlying code, this can be merged in without testing / other deployment-oriented concerns.
Main README
SubjectViewer README
Tasks README
Store README
Store Feedback README