Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Prompting integration test hangs on Windows + Node 14 #453

Closed
t1m0thyj opened this issue Oct 27, 2020 · 2 comments
Closed

Prompting integration test hangs on Windows + Node 14 #453

t1m0thyj opened this issue Oct 27, 2020 · 2 comments
Assignees
@t1m0thyj
Labels
invalid This doesn't seem right testing Issues about testing.

Comments

@t1m0thyj
Copy link
Member

The test in "cli.prompting.integration.test.ts" times out (or hangs in GH Actions). This may be related to the node-pty dev dependency, as it's the only test that uses this native module.
@t1m0thyj t1m0thyj added the testing Issues about testing. label Oct 27, 2020
@t1m0thyj t1m0thyj self-assigned this Oct 28, 2020
@t1m0thyj t1m0thyj mentioned this issue Oct 28, 2020
Closed
@t1m0thyj
Copy link
Member Author

Waiting on microsoft/node-pty#437

@t1m0thyj t1m0thyj added the invalid This doesn't seem right label Aug 6, 2021
@t1m0thyj
Copy link
Member Author

t1m0thyj commented Aug 6, 2021

No longer applicable now that node-pty dependency has been removed in #641

@t1m0thyj t1m0thyj closed this as completed Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@t1m0thyj t1m0thyj

Labels
invalid This doesn't seem right testing Issues about testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix node-pty test hanging on Node 14 + Windows build zowe/imperative
1 participant
@t1m0thyj