ProfileInfo: Identify non-schema properties in the mergedArgs

[ATorrise]

What It Does

How to Test

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

Additional Comments

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f8ca32) 89.76% compared to head (55ed192) 89.76%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1001   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files         211      211           
  Lines       11533    11534    +1     
  Branches     2584     2584           
=======================================
+ Hits        10353    10354    +1     
  Misses       1180     1180           

Files Changed	Coverage Δ
packages/config/src/ProfileInfo.ts	97.54% <100.00%> (+<0.01%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[t1m0thyj]

This doesn't seem to be working for me locally.

Here's what I did:

1. Run zowe config init to create a simple config in my project directory that defines host, user, password, etc.
2. Run the following script to load the default zosmf profile and display all the loaded args:

const { ProfileInfo } = require("@zowe/imperative");
(async () => {
    // Load connection info from default z/OSMF profile
    const profInfo = new ProfileInfo("zowe");
    await profInfo.readProfilesFromDisk();
    const zosmfProfAttrs = profInfo.getDefaultProfile("zosmf");
    const zosmfMergedArgs = profInfo.mergeArgsForProfile(zosmfProfAttrs, { getSecureVals: true });
    console.dir(zosmfMergedArgs);
})();

The offSchema property is false for all the args. I expected it to be true for all of them since I didn't add any custom properties outside the ones defined in the schema.

[traeok]

I was able to confirm that the implementation works 🥳

But, I agree with @t1m0thyj 's suggestion to rename the variable for clarity. Since it would just be a matter of flipping the boolean values for that variable, I'll approve it now, and will re-approve if my review becomes stale due to those changes 😋

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[github-actions]

Release succeeded for the master branch. 🎉

The following packages have been published:

• npm: @zowe/imperative@5.17.0

_{Powered by Octorelease 🚀}