Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Fix abstract rest client (1 of 4) (Imperative V2) #1015

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

awharn
Copy link
Member

@awharn awharn commented Oct 4, 2023

What It Does
Fixes the abstract rest client's implementation of normalization

How to Test

Review Checklist
I certify that I have:

Additional Comments

awharn and others added 3 commits October 3, 2023 13:30
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
packages/rest/src/client/AbstractRestClient.ts 88.51% <100.00%> (+2.49%) ⬆️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn!

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @awharn 😁

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@awharn awharn merged commit 08612bd into master Oct 5, 2023
20 checks passed
@awharn awharn deleted the fix-abstract-rest-client branch October 5, 2023 13:23
@awharn awharn added the release-patch Indicates a patch to existing code has been applied label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Release succeeded for the master branch. 🎉

The following packages have been published:

  • npm: @zowe/imperative@5.18.2

Powered by Octorelease 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants