Update snapshots and workflows for Node 20 #1021
Conversation
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
awharn
requested review from
gejohnston,
zFernand0,
traeok,
KevinLoesch1 and
ATorrise
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Sorry, I think that we miscommunicated about where these changes can be made. I was thinking that we can merge from CLI/master into CLI/add-imp-v2. You were thinking that your changes have to placed into imperative/master because these files do not exist in the master branch of CLI. They only exist in the master branch of imperative.
We can no longer merge from imperative/master into cli/add-imp-v2 because there has been too much structural change.
I think that we have to ask you to discard this PR and create your changes in a local copy of cli/add-imp-v2 that you can then push to the remote version of cli/add-imp-v2.
| @@ -69,8 +69,8 @@ function formatLogLevelMsg(logTypeName: string) { | |||
| export const probTests: IProbTest[] = [ | |||
| { | |||
| itemId: ItemId.NODEJS_VER, | |||
| probExpr: "semver.satisfies('{val}', '<14.x || 15.x || 17.x || >=19.x')", | |||
| probMsg: "Only Node.js versions 14, 16, and 18 are supported." | |||
| probExpr: "semver.satisfies('{val}', '<17.x || 19.x || >=21.x')", | |||
There was a problem hiding this comment.
you will find that this change has already been made in cli/add-imp-v2.
|
It occurs to me that you still have to make these changes to imperative/master just to get the current Zowe release out the door. I approve all of the updates. I just have to ask you to make them again for the CLI/add-imp-v2 branch. Sorry that you have to do duplicated work. |
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
|
@awharn |
What It Does
Changes workflow to use Node 18 and 20
Updates broken snapshots
How to Test
Review Checklist
I certify that I have:
Additional Comments