[WIP] Add App Store app to system apps #537
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidharth Mohanty <sidmohanty11@gmail.com>
This was referenced Jul 19, 2023
Draft
There was a problem hiding this comment.
This is a great start 👍 and a lovely front-end shell w/ a carousel and other cool neat things
Now this needs to communicate with a ZSS dataservice. A next step I'd like to see is, if impossible to communicate with Priyansh's ZSS dataservice right now, can you explore how the Sample React App communicates with a ZSS dataservice and begin creating some rough code from there?
https://github.com/zowe/sample-react-app/blob/v2.x/staging/webClient/src/App.tsx#L215
| icon: ASSETS_URL + "1.png", | ||
| description: | ||
| "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur pellentesque magna a pulvinar venenatis. Aenean dictum pretium sem, eget fermentum risus lobortis dapibus. Nunc fermentum, urna suscipit malesuada sollicitudin, eros libero volutpat elit, quis venenatis ipsum nibh aliquet purus. Cras in metus consectetur, rutrum nisi eget, porttitor odio. Fusce quis egestas ligula, sed tempor odio. Aliquam erat volutpat. Sed eget pharetra massa. Morbi et convallis diam, id imperdiet justo. Maecenas id commodo felis, vel molestie mi. Nulla facilisi.", | ||
| }, |
There was a problem hiding this comment.
Will need to remove later
DivergentEuropeans
changed the title
DivergentEuropeans
requested changes
Aug 29, 2023
Signed-off-by: Sidharth Mohanty <sidmohanty11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds the App Store app as a system app.
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Screenshots/Videos