Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] ProfileInfo API handling of non-profile args #1926

Closed
t1m0thyj opened this issue Mar 31, 2021 · 2 comments
Closed

[next] ProfileInfo API handling of non-profile args #1926

t1m0thyj opened this issue Mar 31, 2021 · 2 comments
Labels
enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits
Milestone

Comments

@t1m0thyj
Copy link
Member

For context (source):

I believe that our agreement with consumers of this API was that we would only process properties that were in a profile (or missing properties that were defined for that profile type).

Some questions which arose in zowe/imperative#579:

  1. If there is no schema present, how will mergeArgsFromProfile know to "only process properties that were in a profile"? Without a schema, it doesn't know that "user" is a profile property and "response-format-json" is not.
  2. When there is a schema present, should mergeArgsForProfile throw an error if non-profile properties like "response-format-json" get loaded into knownArgs?
@MikeBauerCA MikeBauerCA added this to the Backlog milestone Oct 26, 2021
@t1m0thyj t1m0thyj added the question Further information is requested label Nov 29, 2022
@zFernand0
Copy link
Member

I believe that it will be beneficial for application developers (like Zowe Explorer) if we just populated knownArgs with whatever is in the profile, regardless of whether we have a schema to determine if it's a profile property or not.

@zFernand0 zFernand0 added enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits v3 prospective changes for v3 and removed question Further information is requested labels Mar 7, 2023
@zFernand0 zFernand0 modified the milestones: Backlog, Zowe V3 Apr 25, 2023
@awharn awharn transferred this issue from zowe/imperative Nov 13, 2023
@JTonda JTonda removed the v3 prospective changes for v3 label Feb 14, 2024
@t1m0thyj
Copy link
Member Author

All properties are now loaded by the ProfileInfo API and non-schema ones can be distinguished with the inSchema property. Thanks @ATorrise for implementing this in zowe/imperative#1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits
Projects
Status: Closed
Development

No branches or pull requests

4 participants