Fix bug where Vec<f32> would be converted to a non-flat float array in ocaml
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests which generate arrays in rust and then index into them from ocaml. The case for `float array` and `floatarray` from `Vec<f32>` will fail due to these being represented as flat arrays (`float array` might not be a flat array on some systems).
This fixes a bug where `Vec<f32>`s create in rust would be converted to arrays of boxed floats in ocaml.
zshipko
force-pushed
the
fix-flat-float-array-from-f32-vec
branch
from
29c200a
to
64f9bab
Compare
|
Finally passing CI after merging #136 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the treatment of
Vec<f32>to be the same as that ofVec<f64>and adds some tests creatingVecs in rust and then indexing into the resultingarrays in ocaml.