add "always on top" option

zuluwi · Jan 24, 2024 · fd58746 · fd58746
1 parent b387343
commit fd58746
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 9 deletions.
diff --git a/src/language/locale/en.ts b/src/language/locale/en.ts
@@ -25,6 +25,7 @@ export default {
   Port: "Port",
   "Enter the port for the server that will be opened to control VLC Player": "Enter the port for the server that will be opened to control VLC Player",
   //
+  "Always show VLC Player on top": "Always show VLC Player on top",
   "Pause video while pasting timestamp": "Pause video while pasting timestamp",
   "Pause video while pasting snapshot": "Pause video while pasting snapshot",
   //

diff --git a/src/language/locale/tr.ts b/src/language/locale/tr.ts
@@ -25,6 +25,7 @@ export default {
   Port: "Port",
   "Enter the port for the server that will be opened to control VLC Player": "VLC Player'ı kontrol etmek için açılacak server için port giriniz",
   //
+  "Always show VLC Player on top": "VLC Player'ı her zaman üstte göster",
   "Pause video while pasting timestamp": "Zaman damgası yapıştırırken videoyu duraklat",
   "Pause video while pasting snapshot": "Snapshot yapıştırırken videoyu duraklat",
   //

diff --git a/src/settings.ts b/src/settings.ts
@@ -14,6 +14,7 @@ export interface VBPluginSettings {
   lang: string;
   normalSeek: number;
   largeSeek: number;
+  alwaysOnTop: boolean;
   pauseOnPasteLink: boolean;
   pauseOnPasteSnapshot: boolean;
 }
@@ -29,6 +30,7 @@ export const DEFAULT_SETTINGS: VBPluginSettings = {
   lang: "en",
   normalSeek: 5,
   largeSeek: 60,
+  alwaysOnTop: true,
   pauseOnPasteLink: false,
   pauseOnPasteSnapshot: false,
 };
@@ -75,9 +77,9 @@ export class VBPluginSettingsTab extends PluginSettingTab {
     const setCopyBtnDesc = () => {
       copyUrlEl.setDesc(`http://:${this.plugin.settings.port}@localhost:${this.plugin.settings.password}/`);
       copyCommandEl.setDesc(`"${this.plugin.settings.vlcPath}" ${this.plugin.vlcExecOptions().join(" ")}`);
-      copyArgEl.setDesc(`${this.plugin.vlcExecOptions().join(" ").replace(/["]/g, "")}`).descEl.createEl("div", {
-        text: t("Note: If the `--snapshot-path` option contains spaces, the snapshot command will not work (this only happens for Syncplay arguments)"),
-      });
+      // copyArgEl.setDesc(`${this.plugin.vlcExecOptions().join(" ").replace(/["]/g, "")}`).descEl.createEl("div", {
+      //   text: t("Note: If the `--snapshot-path` option contains spaces, the snapshot command will not work (this only happens for Syncplay arguments)"),
+      // });
     };
 
     var selectVLCDescEl: HTMLElement;
@@ -127,6 +129,13 @@ export class VBPluginSettingsTab extends PluginSettingTab {
           })
       );
 
+    new Setting(containerEl).setName(t("Always show VLC Player on top")).addToggle((toggle) => {
+      toggle.setValue(this.plugin.settings.alwaysOnTop).onChange(async (value) => {
+        this.plugin.settings.alwaysOnTop = value;
+        await this.plugin.saveSettings();
+        setCopyBtnDesc();
+      });
+    });
     new Setting(containerEl).setName(t("Pause video while pasting timestamp")).addToggle((toggle) => {
       toggle.setValue(this.plugin.settings.pauseOnPasteLink).onChange((value) => {
         this.plugin.settings.pauseOnPasteLink = value;
@@ -226,12 +235,12 @@ export class VBPluginSettingsTab extends PluginSettingTab {
         new Notice(t("Copied to clipboard"));
       })
     );
-    copyArgEl = new Setting(containerEl).setName(t("Copy arguments for starting VLC (for Syncplay)")).addButton((btn) =>
-      btn.setButtonText(t("Copy to clipboard")).onClick(async () => {
-        await navigator.clipboard.writeText(`${this.plugin.vlcExecOptions().join(" ")}`);
-        new Notice(t("Copied to clipboard"));
-      })
-    );
+    // copyArgEl = new Setting(containerEl).setName(t("Copy arguments for starting VLC (for Syncplay)")).addButton((btn) =>
+    //   btn.setButtonText(t("Copy to clipboard")).onClick(async () => {
+    //     await navigator.clipboard.writeText(`${this.plugin.vlcExecOptions().join(" ")}`);
+    //     new Notice(t("Copied to clipboard"));
+    //   })
+    // );
     setCopyBtnDesc();
 
     //

diff --git a/src/vlcHelper.ts b/src/vlcHelper.ts
@@ -217,6 +217,7 @@ export function passPlugin(plugin: VLCBridgePlugin) {
     `--snapshot-format="${plugin.settings.snapshotExt}"`,
     `--snapshot-prefix="${plugin.settings.snapshotPrefix}-"`,
     `--drawable-hwnd=1`,
+    `${plugin.settings.alwaysOnTop ? "--video-on-top" : ""}`,
   ];
 
   const launchVLC = () => {