Validations #3
Validations #3
Conversation
zunairkhan811
commented
Nov 30, 2023
•
zunairkhan811
commented
- Install gem rspec
- Make validations on models
- Make tests for every model
- Fix linter errors
There was a problem hiding this comment.
Status: Approved ✔️
Hi Zunair,
Blog App -validations and model specs task is complete! 🏁 Great job! Congratulations! 🎉💯🌟
Highlights 🎯
🎲 Model validations properly implemented!
🎲 Added required model validation specs!
🎲 ReadMe looks professional!
Optional suggestions 🧰
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.
You can also consider:
Let's make the ReadMe stand out even better by including instructions under the Getting Started section, on how to run test cases for the app, for instance, using the command rspec.
Happy coding..Keep soaring higher! 💻 🍷 🚀
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.
