Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devise #9

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Add devise #9

merged 7 commits into from
Dec 13, 2023

Conversation

zunairkhan811
Copy link
Owner

  • Implemented all Project Requirements given Below:
    Project requirements:

Copy link

@Abenezer-Tilahun Abenezer-Tilahun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zunairkhan811 @nilab-khwaja

Your project is complete 👍 💯 There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights 👏🏻

✔️ No linter errors.
✔️ You used correct Git-Flow.
✔️ Professional README
✔️ Good Commit Messages.
✔️ Correctly Install and setup devise .
✔️ correctly register new user with email and password, correctly application asks for confirmation of email.
✔️ correctly A user can reset the password in the application and hashed password is stored in the database.
✔️ Good job for Implemented Blog app - add devise.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

@zunairkhan811 zunairkhan811 merged commit b3eed81 into development Dec 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants