-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conservative_retrying #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wRAR
approved these changes
Apr 26, 2024
kmike
reviewed
Apr 29, 2024
kmike
reviewed
Apr 29, 2024
kmike
reviewed
Apr 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 469 558 +89
Branches 56 71 +15
=========================================
+ Hits 469 558 +89
|
Closing and re-opening to verify a fix for the unrelated issue of Codecov uploads… |
…ng responses or network errors as interruptions
kmike
reviewed
May 9, 2024
kmike
reviewed
May 9, 2024
kmike
reviewed
May 9, 2024
kmike
reviewed
May 15, 2024
16 tasks
kmike
reviewed
May 20, 2024
kmike
reviewed
May 20, 2024
Thanks @Gallaecio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like this alternative retry policy will be more useful to most projects. Since changing the default retry policy to something like this would require some discussion, I think it may be a good idea to implement it as an alternative ready-to-use retry policy, so that fewer users need to implement their own custom retry policy.